chore: fixing syntax throwing an error #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wazelin
approved these changes
Feb 5, 2025
Member
|
Ooh. This is pretty bad. Luckily, this issue concerns only the CLI part of the library. Merging and releasing should be sufficient. No need to deploy this anywhere. |
Contributor
|
Thanks for this! You might also want to consider upgrading wp-cli as in the following PR (that I never merged) |
Contributor
|
as well as the usage of relative paths in that exact command, which would be nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is there to fix a small problem, introduced in one of the previous PRs.
As per the customer report, it shows syntax errors when trying to run the command from the SDK readme:
Which is pretty logical, since variable interpolation won't work outside of "string context".