fix coap_socket_strerror() on Windows #1598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows version of
coap_socket_strerror
callscoap_socket_format_errno
with the result ofWSAGetLastError
. At least in my specific case, this results in an "unknown error" message asWSAGetLastError
seems to use different numbers thanstrerror
.coap_io_process_with_fds_lkd
tries to translateWSAGetLastError
toerrno
withcoap_win_error_to_errno
but the Windows version ofcoap_socket_strerror
does not use errno, socoap_win_error_to_errno
is called in vain.With this patch,
coap_win_error_to_errno
is always called in the Windows version ofcoap_socket_strerror
and thenerrno
is passed tocoap_socket_format_errno
and thereforestrerror
.