Skip to content

Conversation

@niotu
Copy link

@niotu niotu commented Jul 20, 2025

No description provided.

@0crat
Copy link

0crat commented Jul 20, 2025

@niotu Hey there! 👋 Just a heads up about your branch name "master" - it's not the best practice for Git branches. Our team policy suggests using ticket numbers instead, like "610" in this case. I know it might seem small, but it helps keep things organized. Unfortunately, this means a -12 point penalty 😕. Next time, let's stick to the convention and keep those points! If you have any questions about naming, just give me a shout.

@yegor256
Copy link
Member

@niotu Thanks for your contribution! Unfortunately, we can't merge it without tests. Every feature we add and every bug we fix must be accompanied by at least one new test that confirms that the code was not working before. Without such a test, how can we know that what you commit actually works?

@niotu
Copy link
Author

niotu commented Jul 21, 2025

@yegor256 Okay, I will add tests in the next pull request related to normalize command.

@0crat Okay, I'll send another pull request with clear naming(610 in this case). Also will this -12 points affect to the course?

@yegor256
Copy link
Member

@niotu we can't merge any code to master without tests. We simply don't know whether your code works or not. And we don't want broken code to go into master.

@yegor256
Copy link
Member

@niotu what's up with this one? Would be great if you can continue and add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants