chore: expose recreate credentials route to admins #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
commented
Mar 11, 2025
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
recreate-credentials
branch
from
554e954 to
0dcb87e
Compare
g-linville
requested review from
drpebcak,
thedadams,
njhale,
tybalex,
StrongMonkey and
iwilltry42
thedadams
approved these changes
Mar 14, 2025
pkg/api/handlers/credentials.go
Outdated
Comment on lines
56
to
61
| err := req.GPTClient.RecreateAllCredentials(req.Context()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
micro-nit:
Suggested change
| err := req.GPTClient.RecreateAllCredentials(req.Context()) | |
| if err != nil { | |
| return err | |
| } | |
| return nil | |
| return req.GPTClient.RecreateAllCredentials(req.Context()) |
There was a problem hiding this comment.
I'm just gonna blame AI for this one lol
Signed-off-by: Grant Linville <[email protected]>
njhale
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1997
depends on gptscript-ai/gptscript#951 (merged)
depends on gptscript-ai/go-gptscript#95 (merged)