Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): correct RecordStateChanged typings #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

fix(types): correct RecordStateChanged typings #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/types.ts
View file
Original file line number Diff line number Diff line change
@@ -590,7 +590,20 @@ export interface OBSEventTypes {
/**
* The specific state of the output
*/
outputState: string;
outputState: 'OBS_WEBSOCKET_OUTPUT_STARTING' | 'OBS_WEBSOCKET_OUTPUT_STOPPING';
} | {
/**
* Whether the output is active
*/
outputActive: boolean;
Comment on lines +593 to +598
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated

/**
* The specific state of the output
*/
outputState: 'OBS_WEBSOCKET_OUTPUT_STARTED' | 'OBS_WEBSOCKET_OUTPUT_STOPPED';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned at the start of this file, this file is auto generated and when there's a new release changes like this will not survive.

Either implement this to obs-websocket repo so docs/generated/protocol.json has this info that the generator can then read (preferred), or update scripts/build-types.ts so the changes persist

/**
* The filename of the output recording
*/
outputPath: string;
};
ReplayBufferStateChanged: {
/**