Updated typings from obs-websocket 5.0.2 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example: `npm run generate:obs-types master` = `GH_COMMIT=master npm run generate:obs-types`
|
Added ability to pass the commit via argv too, a bit easier on windows and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue (if applicable):
#300
Description:
Currently the
generate:obs-typesNPM run script cannot be successfully run, because the latest release fromobs-websocketmaps totag_name4.9.1-compatwhich is not a correct commit (and also not the latest non-deprecated version).In this PR I add the ability to specify a custom commit that we can base the typings off of (using environment variable
GH_COMMIT). Then I use commit5716577019b1ccda01a12db2cba35a023082b7adwhich maps to version 5.0.2 in order to generate the updated typings.Without the
GH_COMMITvariable, the old behavior is kept so that later releases fromobs-websocketwill (hopefully) be automatically picked up.