Allow whitespace after backticks on sql code blocks #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icks The CommonMark specification (0.29 §4.5) allows whitespace between the opening code fence and the info string. Previously, parseInfo() would treat leading whitespace as part of parsing state, causing "``` sql" to be parsed as an empty tag instead of "sql". This fix skips leading whitespace before parsing the tag name, ensuring both "```sql" and "``` sql" are correctly recognized as SQL code blocks, per the CommonMark spec which states that the first word of the info string typically specifies the language for syntax highlighting. Changes: - Modified parseInfo() in src/info.ts to skip leading whitespace before tag parsing - Updated test expectations to verify both formats work correctly - Both code blocks now properly render as Observable SQL blocks with hash IDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fenced code block parsing to allow whitespace after opening backticks
The CommonMark specification (0.29 §4.5) allows whitespace between the opening code fence and the info string. Previously, parseInfo() would treat leading whitespace as part of parsing state, causing "``` sql" to be parsed as an empty tag instead of "sql".
This fix skips leading whitespace before parsing the tag name, ensuring both "
sql" and "sql" are correctly recognized as SQL code blocks, per the CommonMark spec which states that the first word of the info string typically specifies the language for syntax highlighting.Changes:
I encountered this issue because I use
comrakto autoformat markdown files.comraknormalizes markdown to include a space after the backticks.