Skip to content

linux-pipewire: Forbid screencast source duplication#13673

Open
tytan652 wants to merge 1 commit into
obsproject:masterfrom
tytan652:screen_cast_no_dup
Open

linux-pipewire: Forbid screencast source duplication#13673
tytan652 wants to merge 1 commit into
obsproject:masterfrom
tytan652:screen_cast_no_dup

Conversation

@tytan652

@tytan652 tytan652 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Description

Each instance holds a unique session with a unique restore token. Which both can not be duplicated.

Motivation and Context

@mihawk90 reported issues with those in Studio Mode with "Duplicate Sources" enabled, which revealed bugs due to the unique nature of each instance of those.

How Has This Been Tested?

Locally, the source is no longer duplicated in the in Studio Mode with "Duplicate Sources" enabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Each instance holds a unique session with a unique restore token.
Which both can not be duplicated.
@tytan652 tytan652 added Seeking Testers Build artifacts on CI kind/bug Categorizes issue or PR as related to a bug. platform/linux Categorizes issue or PR as affecting Linux specifically labels Jul 20, 2026
@mihawk90

Copy link
Copy Markdown
Contributor

For reference, the issue at hand is this:

Screencast_20260720_074301.webm

@github-project-automation github-project-automation Bot moved this to Ready For Review in 33.0 Release Tracker Jul 20, 2026
@Warchamp7 Warchamp7 moved this from Ready For Review to Ready For Merge in 33.0 Release Tracker Jul 20, 2026
@RytoEX

RytoEX commented Jul 20, 2026

Copy link
Copy Markdown
Member

@mihawk90 Does this fix the behavior you encountered?

@mihawk90

Copy link
Copy Markdown
Contributor

I haven't been able to build it yet, will probably get around to it in ~2h or so and will report back

@mihawk90

Copy link
Copy Markdown
Contributor

Yes works as expected. Only one screencast indicator and the transition happens instantly.

Can also still manipulate in Preview without affecting the Program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. platform/linux Categorizes issue or PR as affecting Linux specifically Seeking Testers Build artifacts on CI

Projects

Status: Ready For Merge

Development

Successfully merging this pull request may close these issues.

5 participants