Conversation
jjyyxx
requested changes
Jul 3, 2018
Member
There was a problem hiding this comment.
首先,感谢这一项及时的工作!完全基于正则表达式的匹配在tmd的section的匹配上遇到一定困难,状态机很有希望有效解决这一问题。
但在合并之前,应当解决劣势中1、2所提及的问题,并进行充分的测试。该部分更改基本全部处于lib/tmdoc中,对其他部分的继续开发不构成阻碍。
希望@shigma对状态机及rules等引入的概念提供一定的注释,进行说明,方便大家共同参与解决问题,并进一步改进。
pr保留,并在new-lexer分支上进一步调试,在解决以上两个问题后进行合并。
# Conflicts: # build/index.js
Member
|
现在new-lexer分支可以进行调试了,从我的初步测试来看,除了小节线,,API的Setting、Ammonia的overview都出现了卡死的状况,亟待解决。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一个新的 Lexer,利用状态机实现。
优势:
劣势:
希望大家能帮忙解决这些问题。