Add Stdlib type equality to Set.Make, Map.Make and Hashtbl.Make #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
changed the title
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most types batteries already has such type equalities, but crucially for
BatSet.Make,BatMap.MakeandBatHashtbl.Makethey were missing. Containers has the same type equalities exposed.These are particularly useful for when batteries lags behind
Stdlib(which can often happen nowadays) and one wants to use some functions from batteries, but also new ones fromStdlib. This type equality makes it at least possible without having to immediately patch batteries every time and wait for a release.