Skip to content

fix utoprc templates to mention the correct path (changed by #484)#506

Merged
Octachron merged 1 commit into
ocaml-community:masterfrom
qexat:fix/utoprc-templates
Aug 12, 2025
Merged

fix utoprc templates to mention the correct path (changed by #484)#506
Octachron merged 1 commit into
ocaml-community:masterfrom
qexat:fix/utoprc-templates

Conversation

@qexat

@qexat qexat commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

The path for utoprc used to be $XDG_CONFIG_HOME/utoprc, but #484 has changed it to $XDG_CONFIG_HOME/utop/utoprc -- as the former was rightfully deemed incorrect.

However, the utoprc-dark and utoprc-light templates were not updated in the process ; this PR fixes exactly that.


It's worth mentioning that the aforementioned PR introduced a breaking change: people with their utoprc in the previous location will not have code highlighting working anymore, and it is not necessarily clear why that is. I think there should be a transition period where a warning is shown if a utoprc is found in .config/ instead of .config/utop/.

@qexat
qexat requested a review from rgrinberg as a code owner August 8, 2025 10:09
@Octachron

Copy link
Copy Markdown
Member

Thanks for the fix !

Emitting a warning for misplaced .utoprc sounds like a good idea. I would be willing to merge such PR; however, I don't have the bandwidth to implement it personally.

@qexat

qexat commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

I think I'll work on it tomorrow (CEST)

@Octachron
Octachron merged commit 33201e6 into ocaml-community:master Aug 12, 2025
3 checks passed
@qexat
qexat deleted the fix/utoprc-templates branch August 12, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants