add test for module type decl in signature item #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ps-id: d0989bfd-2d2a-4182-89bb-40edf8006617 -->
tatchi
force-pushed
the
ps/rr/add_test_for_module_type_decl_in_signature_item
branch
from
8b343f2 to
a2288ce
Compare
|
Hey @ejgallego, it would be nice if you could take a look at this PR (and the other 2). I plan to open another one with the new module type syntax once they're merged. 🤗 |
|
Hey @ejgallego, friendly reminder that it would be super nice if you could review the few PR's I've opened when you have time 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be helpful for the new module type syntax to make sure we support that case