Skip to content

Conversation

@tmcgilchrist
Copy link
Contributor

Pure OCaml implementation of Apache Avro

CHANGES:

Initial relase for avro-simple

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I can see runtest is timing out on 32-bit (both x86_32 and arm32) after 2 hours.

If you want to investigate locally what is causing it, something like the following should start a 32-bit docker image:

docker run -it --platform linux/i386 ocaml/opam:debian-12-ocaml-5.4

A quicker fix would be to guard runtest with arch != "arm32" & arch != "x86_32"

@tmcgilchrist
Copy link
Contributor Author

Weird. Those timeouts seem to be infrastructure related, both timed out trying to install dependencies rather than compiling or running tests, plus I'm using this library in JSOO without issues.

@jmid
Copy link
Member

jmid commented Nov 17, 2025

Hm, it happened again on x86_32 and arm32, despite rerunning CI and it still triggers when run with --with-test:

/home/opam: (run (network host)
                 (shell "(opam reinstall --with-test avro-simple.0.1) || true"))

Will this also runtest for the dependencies?

I can see QCheck installed as a dependency, for which a shrinker loop could explain the observed behaviour.
Are there any non-trivial false PBTs in avro-simple or custom shrinker algorithms? (admittedly it could potentially also be surfacing a corner-case that I've overlooked...) 🤔

@tmcgilchrist
Copy link
Contributor Author

Turns out some of the property tests are long running and might be the cause of those timeouts. Let me remove those from the opam test command and I'll update the source for this PR.

@tmcgilchrist
Copy link
Contributor Author

Now I've given up and just disabled those platforms bcff42d I haven't been able to reproduce the issue using docker

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@tmcgilchrist
Copy link
Contributor Author

tmcgilchrist commented Nov 19, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants