Upgrade opam root: add conditionnal hard upgrade#6949
Open
rjbou wants to merge 2 commits into
Open
Conversation
rjbou
commented
May 29, 2026
rjbou
commented
May 29, 2026
rjbou
commented
May 29, 2026
rjbou
commented
May 29, 2026
rjbou
commented
May 29, 2026
rjbou
commented
May 29, 2026
rjbou
force-pushed
the
conditional-upgrade-opamroot
branch
from
1cc3b11 to
8b8f5d9
Compare
rjbou
commented
May 29, 2026
Comment on lines
+1297
to
+1298
| v, f, cond | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| v, f, cond | |
| ) | |
| v, f, cond) |
Collaborator
Author
|
Reviewed by @kit-ty-kate: lgtm |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6625, we need to perform an hard upgrade for a specific case that is not common.
We add then a in this PR a mechanism to perform conditional hard upgrade, like that most people are not affected by the hard upgrade.
We also add some invariant on conditional hard upgrade, if there is a conditional hard upgrade on a version X:
In the story of #6625