Repository navigation
fix(recall-gate): score sufficiency on vector relevance, not fused rank #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hidb4ai
merged 1 commit into
oceanbase:master
from
delete-cloud:fix/recall-gate-cosine-signal-rebased
Oct 10, 2026
+917
−258
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I walked through this and think the current behavior is the defensible one, not a loss: a candidate that gains an admitted vector channel only under the lowered floor always has cosine below the round-zero baseline (0.3), and
_score_signalsuses only at-or-above-baseline scores for the gap and can only lowertop_scorewith below-baseline values. Promoting such a scope to scored would risk exactly the wrong outcome - converting a recoverable thin-candidates case into a terminalweak-top-1on a 0.25 cosine. The RFC states this rule explicitly ("lower-ranked vector hits cannot turn an FTS-only first hit into a weak score"), and the accumulated candidate order keeps round 0 first, so the first-hit rule stays invariant to expansion order (there is an e2e test pinning exactly that). If the admitted-pool top cosine is ever surfaced to the gate (the separate fusion-limitgap), that would be the point to revisit this too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed — this matches the intended invariant: a vector row that only survives the lowered floor is by construction below the 0.3 baseline, so promoting it to scored would invert a recoverable
thin-candidatesround intoweak-top-1on a below-threshold cosine. No change needed; the per-Scope first-hit rule and the ordering e2e test pin this.