-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/paid auth extra commands #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # package-lock.json # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be useful to have tests for generate auth token commands too?
Also for deposit in escrow command, maybe it is worthy to display to the end user how much available funds has in escrow and waits for its input (y/n) if the user still wants to deposit the amount, deposit action should not happen often (at every compute job) and I think it is useful to show to the user what already has in terms of funds.
EDIT: create a new command of checking escrow funds available, one for withdraw.
mariacarmina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion from my side to display the authorizations within check funds command (I do not mind if we'll change the name for the command to be more intuitive for the user).
Looks good, after this modification we can merge this.
Thank you @giurgiur99!
mariacarmina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #122
Changes proposed in this PR: