Skip to content

Conversation

@giurgiur99
Copy link
Contributor

@giurgiur99 giurgiur99 commented Jun 16, 2025

Fixes #122

Changes proposed in this PR:

  • New methods: Generate new auth token, invalidate auth token, deposit, authorize, withdraw, getUserFunds

@giurgiur99 giurgiur99 marked this pull request as ready for review June 16, 2025 07:38
Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be useful to have tests for generate auth token commands too?
Also for deposit in escrow command, maybe it is worthy to display to the end user how much available funds has in escrow and waits for its input (y/n) if the user still wants to deposit the amount, deposit action should not happen often (at every compute job) and I think it is useful to show to the user what already has in terms of funds.
EDIT: create a new command of checking escrow funds available, one for withdraw.

Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion from my side to display the authorizations within check funds command (I do not mind if we'll change the name for the command to be more intuitive for the user).
Looks good, after this modification we can merge this.

Thank you @giurgiur99!

Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@giurgiur99 giurgiur99 merged commit 93beda0 into main Jun 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paid compute cli commands

3 participants