C2D V2 fixes #72
Closed
C2D V2 fixes #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Let's focus on testing and fixing the bugs in the PR on the node (oceanprotocol/ocean-node#705) first. |
Contributor
Author
Ok, but these changes are needed, don't just think in terms of directCommand ... all these changes + the SDK are needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR:
Needed for testing C2D V2
We should test using SDK branch https://github.com/oceanprotocol/ocean.js/tree/release_4.0_C2D_V2 npm link and install locally or from repo & branch
npm install https://github.com/oceanprotocol/ocean.js#release_4.0_C2D_V2npm link @oceanprotocol/lib