-
Notifications
You must be signed in to change notification settings - Fork 6
Release SDK 4.0 C2D V2 #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
̶C̶a̶n̶ ̶w̶e̶ ̶m̶e̶r̶g̶e̶ ̶m̶a̶i̶n̶ ̶i̶n̶ ̶t̶h̶i̶s̶ ̶b̶r̶a̶n̶c̶h̶?̶ ̶S̶i̶n̶c̶e̶ ̶h̶t̶t̶p̶s̶:̶/̶/̶g̶i̶t̶h̶u̶b̶.̶c̶o̶m̶/̶o̶c̶e̶a̶n̶p̶r̶o̶t̶o̶c̶o̶l̶/̶o̶c̶e̶a̶n̶-̶c̶l̶i̶/̶p̶u̶l̶l̶/̶1̶0̶1̶ ̶w̶a̶s̶ ̶m̶e̶r̶g̶e̶d̶ ̶i̶n̶ ̶m̶a̶i̶n̶.̶ Already merged in last commit. |
mariacarmina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions from my side.
|
@bogdanfazakas check my latest change (the c2d env var was not set) |
Fixes # .
#92
Changes proposed in this PR:
Needed for testing C2D V2
startFreeComputeand PAIDstartComputecompute jobs... they have separate flows and FREE compute jobs do not requireinitializeComputelogicgetComputeEnvironments" (useful because we need the environment ID to start a compute job)