Skip to content

fix: update admin handlers validation to accept smart wallet signatures #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndrpp merged 7 commits into from
Dec 17, 2025
Merged

fix: update admin handlers validation to accept smart wallet signatures #1124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be36f41
feat: add logs to get/push config p2p handlers
ndrpp Dec 16, 2025
31447b4
feat: use ERC1271 validation function for smart account calls
ndrpp Dec 16, 2025
bb9a1bb
feat: improve admin validation + add more logs for debugging
ndrpp Dec 16, 2025
fa46ce7
fix: hex the input message in case it's a smart account signature
ndrpp Dec 17, 2025
f06f952
chore: cleanup
ndrpp Dec 17, 2025
c1c1a18
fix: use correct hashing function for smart wallets sig validation
ndrpp Dec 17, 2025
d8eedfd
fix: use correct chainId for validation
ndrpp Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/core/admin/fetchConfigHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ export class FetchConfigHandler extends AdminCommandHandler {
}

async handle(task: AdminFetchConfigCommand): Promise<P2PCommandResponse> {
console.log({ task, message: 'FETCH_CONFIG_P2P_COMMAND' })
const validation = await this.validate(task)
console.log({ validation, message: 'FETCH_CONFIG_P2P_COMMAND' })
if (!validation.valid) {
return new Promise<P2PCommandResponse>((resolve) => {
resolve(buildInvalidParametersResponse(validation))
Expand All @@ -25,6 +27,10 @@ export class FetchConfigHandler extends AdminCommandHandler {
const config = loadConfigFromFile()
config.keys.privateKey = '[*** HIDDEN CONTENT ***]'

console.log({
responseConfig: JSON.stringify(config),
message: 'FETCH_CONFIG_P2P_COMMAND'
})
return new Promise<P2PCommandResponse>((resolve) => {
resolve({
status: { httpStatus: 200 },
Expand Down
6 changes: 6 additions & 0 deletions src/components/core/admin/pushConfigHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,18 @@
}

async handle(task: AdminPushConfigCommand): Promise<P2PCommandResponse> {
console.log({ task, message: 'PUSH_CONFIG_P2P_COMMAND' })
const validation = await this.validate(task)
if (!validation.valid) {
return new Promise<P2PCommandResponse>((resolve) => {
resolve(buildInvalidParametersResponse(validation))
})
}
console.log({ validation, message: 'PUSH_CONFIG_P2P_COMMAND' })

try {
const configPath = getConfigFilePath()
const configContent = await fs.promises.readFile(configPath, 'utf-8')

Check warning on line 57 in src/components/core/admin/pushConfigHandler.ts

View workflow job for this annotation

GitHub Actions / lint 

Found readFile from package "fs" with non literal argument at index 0
const currentConfig = JSON.parse(configContent)

const mergedConfig = { ...currentConfig, ...task.config }
Expand All @@ -62,6 +64,10 @@
newConfig.keys.privateKey = '[*** HIDDEN CONTENT ***]'
CORE_LOGGER.logMessage('Configuration reloaded successfully')

console.log({
responseConfig: JSON.stringify(newConfig),
message: 'PUSH_CONFIG_P2P_COMMAND'
})
return new Promise<P2PCommandResponse>((resolve) => {
resolve({
status: { httpStatus: 200 },
Expand All @@ -82,7 +88,7 @@
private async saveConfigToFile(config: Record<string, any>): Promise<void> {
const configPath = getConfigFilePath()
const content = JSON.stringify(config, null, 4)
await fs.promises.writeFile(configPath, content, 'utf-8')

Check warning on line 91 in src/components/core/admin/pushConfigHandler.ts

View workflow job for this annotation

GitHub Actions / lint 

Found writeFile from package "fs" with non literal argument at index 0
CORE_LOGGER.logMessage(`Config saved to: ${configPath}`)
}
}
Loading