Skip to content

recalculate code hash if needed #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paulo-ocean merged 2 commits into from
Dec 17, 2024
Merged

recalculate code hash if needed #790

paulo-ocean merged 2 commits into from
Dec 17, 2024

Conversation

@paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Dec 9, 2024

Fixes #772

Changes proposed in this PR:

  • code hash might need to be recalculated if config object does not contain key (e.g: after a config reload)
  • this absence can cause the system tests to fail (property codeHash missing on the status command)

@paulo-ocean paulo-ocean self-assigned this Dec 9, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review December 9, 2024 14:47
jamiehewitt15
jamiehewitt15 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

mariacarmina
mariacarmina approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulo-ocean paulo-ocean merged commit e42ada6 into main Dec 17, 2024
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-772-missing-code-hash branch December 17, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

2 more reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@mariacarmina mariacarmina mariacarmina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mariacarmina mariacarmina

@paulo-ocean paulo-ocean

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

codeHash (and maybe other fields) are missing on the "status" directCommand

4 participants

@paulo-ocean @jamiehewitt15 @mariacarmina