add datasets on ComputeAsset, new start compute fn #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit e1c5194 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 75.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 70.6% (-1.0% change). View more on Code Climate. |
Member
|
can you change the commit target to https://github.com/oceanprotocol/ocean.js/tree/release_4.0 please ? |
paulo-ocean
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15,
mariacarmina and
mihaisc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867 .
Changes proposed in this PR:
datasetsmerged withadditionalAssets, add supportsfileObject