chore: signDDO #1877
Closed
chore: signDDO #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdriGeorge
requested review from
alexcos20,
bogdanfazakas,
jamiehewitt15,
mariacarmina,
mihaisc and
paulo-ocean
as code owners
paulo-ocean
reviewed
Nov 20, 2024
Contributor
There was a problem hiding this comment.
how do we know if the functions like signCredential and signCredentialWithWaltId actually do what's expected? I don't see any usage of these, no unit tests, etc? And the 'privateKey' is supposed to be sent clear text? (i don't think we have any similar case)
Contributor
|
You haven't referenced an issue, and there is also no documentation on any of these changes, so it is difficult to review and evaluate whether the original objective has been met. |
| "dependencies": { | ||
| "@oasisprotocol/sapphire-paratime": "^1.3.2", | ||
| "@oceanprotocol/contracts": "^2.2.0", | ||
| "axios": "^1.7.7", |
Contributor
There was a problem hiding this comment.
Why have you added axios when we already have cross-fetch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: