Skip to content

New type for docker image, oom, envs #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giurgiur99 merged 2 commits into from
Oct 20, 2025
Merged

New type for docker image, oom, envs #135

giurgiur99 merged 2 commits into from
Oct 20, 2025

Conversation

@giurgiur99
Copy link
Contributor

@giurgiur99 giurgiur99 commented Oct 17, 2025 •
edited
Loading

Fixes #134

Changes proposed in this PR:

  • Created a new job type 'Docker image'. It can run docker images without algos. Use-case scenarios: benchmarking, pre-built images, etc
  • Display whn algo is OOM killed
  • Send env vars with algo

@giurgiur99 giurgiur99 marked this pull request as ready for review October 17, 2025 13:51
@giurgiur99 giurgiur99 changed the title oom, envs New type for docker image, oom, envs Oct 20, 2025
@alexcos20
Copy link
Member

alexcos20 commented Oct 20, 2025

Tested OOM: works fine

Tested only docker image:
image

alexcos20
alexcos20 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giurgiur99 giurgiur99 merged commit cafa31b into main Oct 20, 2025
1 check passed
@giurgiur99 giurgiur99 deleted the 134-allow-jobs-with-no-content-to-be-started branch October 20, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas

@denisiuriet denisiuriet Awaiting requested review from denisiuriet

@ndrpp ndrpp Awaiting requested review from ndrpp

@andreip136 andreip136 Awaiting requested review from andreip136

Assignees

@giurgiur99 giurgiur99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow jobs with no content to be started

3 participants

@giurgiur99 @alexcos20