Peer ids #141
Merged
Peer ids #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giurgiur99
requested review from
alexcos20,
andreip136,
bogdanfazakas,
denisiuriet and
ndrpp
ndrpp
reviewed
Nov 18, 2025
src/helpers/direct-command.ts
Outdated
|
|
||
| const MAX_RETRIAL_NUMBER = 5; | ||
|
|
||
| export const directNodeCommand = async (command: string, peerId: string, body: any, signerOrAuthToken?: Signer | string | null, retrialNumber: number = 0): Promise<any> => { |
Member
There was a problem hiding this comment.
I think it would be cleaner to have the command as an enum instead of a string
ndrpp
approved these changes
Dec 2, 2025
denisiuriet
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
Changes proposed in this PR: