Make test independent from build directory state #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modified test could fail if the directory it's run in already contained a file named `append.txt`, which sometimes happened when the test has already been run previously by Dune, possibly with a different backend or profile.
|
Fixes the test currently failing on master. |
|
This is probably no longer needed for the CI since ocaml/dune#12243 has been fixed in dune 3.20.1. But it makes the test more robust. |
|
Since the compiler can be built with Dune 3.19 or newer, it can still be useful to correctly run the testsuite locally. |
|
can this be fixed with dune locks ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modified test could fail if the directory it's run in already contained a file named
append.txt, which sometimes happened when the test has already been run previously by Dune, possibly with a different backend or profile.