Repository navigation
fix(api): decode underage on player profiles - #67
Merged
Merged
Conversation
oddsfeedschema declares underage on the player type from v1.1.0; the schema conformance test fails on a declared attribute without a Go field. Internal model only, the public Underage accessor on Player is a follow-up. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 25, 2026
dsaiko
approved these changes
Sep 25, 2026
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
oddsfeedschema declares
underageon theplayertype from v1.1.0 (oddin-gg/oddsfeedschema#22), with the same-1unknown /0no /1yes encoding ascompetitor@underage.internal/schemacheckfollows oddsfeedschemamain, so a declared attribute without a Go field fails the SDK build. This adds the field to the internal player model.Scope: internal model only. A public
Underageaccessor ontypes.Playeris a follow-up.Merge order
Merge oddin-gg/oddsfeedschema#22 first, then re-run CI here. The schema test compares against oddsfeedschema
mainin both directions, so until the schema lands this PR fails withsdk-only attribute /player_profile/player@underage— that is the expected red, not a bug. After the schema merges,mainhere fails the same way in reverse (schema-only attribute) until this PR merges, so land the two back to back.Verification
ODDSFEEDSCHEMA_DIR=<schema branch> go test -count=1 ./...— green; againstODDSFEEDSCHEMA_REF=mainred on exactly the twounderageslots (/player_profile/player,/competitor_profile/players/player), nothing else.schema-only attribute /player_profile/player@underage.gofmt,go vetclean.🤖 Generated with Claude Code