Skip to content

Add underage to the player type #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yung-madamm merged 1 commit into from
Sep 25, 2026
Merged

Add underage to the player type #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions schema/rest/types/player.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@
<xs:attribute type="xs:string" name="name" use="required"/>
<xs:attribute type="sportUrn" name="sport" use="required"/>
<xs:attribute type="xs:string" name="full_name"/>
<!-- -1 unknown, 0 not underage, 1 underage; same encoding as team@underage -->
<xs:attribute type="xs:integer" name="underage"/>
</xs:complexType>
</xs:schema>
2 changes: 1 addition & 1 deletion test/fixtures/rest/competitor/competitor_profile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
<sport id="od:sport:1" name="League of Legends" abbreviation="LoL"/>
</competitor>
<players>
<player id="od:player:9001" name="Player One" sport="od:sport:1" full_name="Player One Full"/>
<player id="od:player:9001" name="Player One" sport="od:sport:1" full_name="Player One Full" underage="-1"/>
</players>
</competitor_profile>
2 changes: 1 addition & 1 deletion test/fixtures/rest/player/player_profile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<player_profile generated_at="2026-08-26T12:00:00">
<player id="od:player:9001" name="Player One" sport="od:sport:1"/>
<player id="od:player:9001" name="Player One" sport="od:sport:1" underage="1"/>
</player_profile>
Loading