-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the digital ocean section #277
base: outreachy2024
Are you sure you want to change the base?
Conversation
src/sync-endpoint-cloud-setup.rst
Outdated
.. image:: /img/setup-digital-ocean/do11.png | ||
:width: 600 | ||
|
||
6. After going through the instructions for :ref:`Creating a Sample User <sync-endpoint-setup-create-user>`, we no longer need access to this admin interface anymore. This admin interface is running on port 40000, and in order to ensure that this admin interface is not publicly accessible to anyone, we want to remove the rule that accepts incoming traffic to that port. Go ahead and remove the following rule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you say (in brief) what rule is being removed so it parallels the picture?
src/sync-endpoint-cloud-setup.rst
Outdated
|
||
.. image:: /img/setup-digital-ocean/do-console-terminal.png | ||
:width: 600 | ||
|
||
4. Before running our launch scripts, we need to check our logs to ensure that all the packages have been successfully installed, which should take about 2-3 minutes. The droplet may also reboot in this time. | ||
3. Before running our launch scripts, we need to check our logs to ensure that all the packages have been successfully installed, which should take about 2-3 minutes. The droplet may also reboot in this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for consistency of style, "we need to check our logs" should be "you need to check your logs"
Great progress doing a ton of updates! Just a couple minor comments. @wbrunette do you want to review as well or shall I approve after the couple of fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! @wbrunette do you want to review or should I merge?
src/sync-endpoint-cloud-setup.rst
Outdated
.. image:: /img/setup-digital-ocean/do-firewall.png | ||
:width: 600 | ||
|
||
5. Set a name for your firewall and modify the inbound rules to match the inbound rules specified in the picture below (SSH, HTTP, HTTPS and port (40000) for admin interface). Attach the firewall to the desired droplet. Leave the outbound rules as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a warning do not leave 40000 open. We should think about adding SSH tunnel instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean opening the port to a specific IP address instead of leaving it open to traffic from anywhere? Because there is an instruction asking the user to remove that port after creating a user.
Yes, I did. I'll send in a commit with the updates. I needed to update the screenshots of the firewall settings for the cloud platforms but had an issue with my Azure account that's why this took a while. |
@Goodiec, I was wondering if you had an update? |
Yes, I've updated the PR, sorry it took this long. Kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Goodiec this looks good to me, although @wbrunette should probably check the technical details!
What is included in this PR?
Updates the digital ocean section of the cloud sync endpoint page