Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the digital ocean section #277

Open
wants to merge 7 commits into
base: outreachy2024
Choose a base branch
from

Conversation

Goodiec
Copy link
Contributor

@Goodiec Goodiec commented Feb 23, 2024

What is included in this PR?

Updates the digital ocean section of the cloud sync endpoint page

@Goodiec Goodiec changed the base branch from main to outreachy2024 February 23, 2024 12:35
.. image:: /img/setup-digital-ocean/do11.png
:width: 600

6. After going through the instructions for :ref:`Creating a Sample User <sync-endpoint-setup-create-user>`, we no longer need access to this admin interface anymore. This admin interface is running on port 40000, and in order to ensure that this admin interface is not publicly accessible to anyone, we want to remove the rule that accepts incoming traffic to that port. Go ahead and remove the following rule:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you say (in brief) what rule is being removed so it parallels the picture?


.. image:: /img/setup-digital-ocean/do-console-terminal.png
:width: 600

4. Before running our launch scripts, we need to check our logs to ensure that all the packages have been successfully installed, which should take about 2-3 minutes. The droplet may also reboot in this time.
3. Before running our launch scripts, we need to check our logs to ensure that all the packages have been successfully installed, which should take about 2-3 minutes. The droplet may also reboot in this time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency of style, "we need to check our logs" should be "you need to check your logs"

@elmps2018
Copy link
Contributor

Great progress doing a ton of updates! Just a couple minor comments. @wbrunette do you want to review as well or shall I approve after the couple of fixes?

Copy link
Contributor

@elmps2018 elmps2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! @wbrunette do you want to review or should I merge?

.. image:: /img/setup-digital-ocean/do-firewall.png
:width: 600

5. Set a name for your firewall and modify the inbound rules to match the inbound rules specified in the picture below (SSH, HTTP, HTTPS and port (40000) for admin interface). Attach the firewall to the desired droplet. Leave the outbound rules as-is.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a warning do not leave 40000 open. We should think about adding SSH tunnel instructions.

Copy link
Contributor Author

@Goodiec Goodiec Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean opening the port to a specific IP address instead of leaving it open to traffic from anywhere? Because there is an instruction asking the user to remove that port after creating a user.

@wbrunette
Copy link
Member

oops not @teelda, I meant @Goodiec.
@Goodiec did you get a chance to create the SSH tunnel documentation we talked about?

@Goodiec
Copy link
Contributor Author

Goodiec commented Mar 11, 2024

Yes, I did. I'll send in a commit with the updates. I needed to update the screenshots of the firewall settings for the cloud platforms but had an issue with my Azure account that's why this took a while.

@wbrunette
Copy link
Member

@Goodiec, I was wondering if you had an update?

@Goodiec
Copy link
Contributor Author

Goodiec commented Mar 19, 2024

@Goodiec, I was wondering if you had an update?

Yes, I've updated the PR, sorry it took this long. Kindly review.

Copy link
Contributor

@elmps2018 elmps2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Goodiec this looks good to me, although @wbrunette should probably check the technical details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants