-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[IMP] accouting/l10n_br: Adding information about credit usage in the Avalara integration .rst #13630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
o comply with legal requirements—especially consumer protection laws (Lei de Proteção ao Consumidor) — and to ensure full transparency with our users, we provide the following explanation of how credit consumption works in the Avalara integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @giri-odoo
Thanks for the PR with the improvements!
I left some comments as part of my pre-review, this PR will be reviewed by other teams after I conclude my review.
Help me improving the PR and commit title, you can take the PR done by @sclo-odoo here #12921
Example: [IMP] accouting/l10n_br: Adding NFC-e feature
That is the title convention needed. You can try using the GitHub desktop to make that edit, try here on the web-based GitHub, if close and create a new PR if those 2 steps weren't possible.
Thanks again!
- Correction letter (Carta de Correção) | ||
- Invoice cancellation | ||
- Other tax validations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Correction letter (Carta de Correção) | |
- Invoice cancellation | |
- Other tax validations | |
- :ref:`Correction letter (Carta de Correção) <localizations/brazil/correction-letter>` | |
- :ref:`Invoice cancellation <localizations/brazil/invoice-cancellation>` | |
- :ref:`Sales Refund via Credit Note <localizations/brazil/credit-notes>` | |
- :ref:`Sales Complementary Invoice via Debit Note <localizations/brazil/debit-notes>` | |
- :ref:`Invalidate invoice number range <localizations/brazil/invalidate-invoice-number-range>` | |
- Other tax validations. |
Please do the same for the NFS-e section.
Feel free to modify of add cases, but if we are gonna add the detailed consumption, it is better to add all scenarios where a credit is consumed, which is every time a API call is done, like in the added scenarios. I've added the links to the specific section within the User Doc as we have it, and it is good to refer the user to that section if needed.
For Credit Notes (sales refund) and Debit Notes (Sales Complementary), there's also a Tax Computation required, so maybe you would like to add that a Tax Computation will be consumed on those scenarios as well.
:ref:create an account in AvaTax <localizations/brazil/avatax-account>
.. important:: | ||
The Avalara integration operates on a credit-based system, where each interaction with Avalara consumes 1 credit. Below are the main credit-consuming operations: | ||
|
||
:guilabel:`Sales Application`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes on the NF-e section also applies here.
Co-authored-by: Valentino <[email protected]>
Co-authored-by: Valentino <[email protected]>
… Avalara integration.rst Update informations
@vbe-odoo Thanks for the feedback! I've already made all the changes. |
Hello @giri-odoo, thanks for the changes. Just a few remarks:
Thanks! |
To comply with legal requirements—especially consumer protection laws (Lei de Proteção ao Consumidor) — and to ensure full transparency with our users, we provide the following explanation of how credit consumption works in the Avalara integration.