-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[IMP] Lunch: Update orders #13632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[IMP] Lunch: Update orders #13632
Conversation
Hi @slinkous - this is ready for a peer review when you have a moment! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update. There was one line (mostly from previous version) that I called out as confusing. The rest is superficial stuff.
When the *Lunch* application is opened, the :guilabel:`Order Your Lunch` dashboard loads. This view | ||
is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`. | ||
When the **Lunch** application is opened, the :guilabel:`Order Your Lunch` dashboard loads. This | ||
view is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
view is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`. | |
view is also accessible by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`. |
Just to break up some of the passive voice verbs (opened, loads)
opening the **Lunch** app, or by navigating to :menuselection:`Lunch app --> My Lunch --> New | ||
Order`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused. You either open the app, or you open the app and do two more things and these are equivalent?
|
||
.. image:: orders/your-order.png | ||
:align: center | ||
:alt: The Your Orders section of the dashboard, with the purchasing information highlighted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda think "Your Orders" or 'Your Orders' because it's syntactically disruptive if you don't call it out as a label.
Updating to new standards and updating images.
Task card for this PR.