Skip to content

[IMP] Lunch: Update orders #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

Conversation

larm-odoo
Copy link
Contributor

Updating to new standards and updating images.

Task card for this PR.

@larm-odoo larm-odoo self-assigned this Jun 9, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jun 9, 2025

Pull request status dashboard

@larm-odoo larm-odoo added the 2 label Jun 9, 2025
@larm-odoo larm-odoo requested a review from slinkous June 9, 2025 20:35
@C3POdoo C3POdoo requested a review from a team June 9, 2025 20:36
@larm-odoo
Copy link
Contributor Author

Hi @slinkous - this is ready for a peer review when you have a moment!

Copy link
Contributor

@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update. There was one line (mostly from previous version) that I called out as confusing. The rest is superficial stuff.

When the *Lunch* application is opened, the :guilabel:`Order Your Lunch` dashboard loads. This view
is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`.
When the **Lunch** application is opened, the :guilabel:`Order Your Lunch` dashboard loads. This
view is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
view is also accessed by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`.
view is also accessible by navigating to :menuselection:`Lunch app --> My Lunch --> New Order`.

Just to break up some of the passive voice verbs (opened, loads)

Comment on lines +54 to +55
opening the **Lunch** app, or by navigating to :menuselection:`Lunch app --> My Lunch --> New
Order`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. You either open the app, or you open the app and do two more things and these are equivalent?


.. image:: orders/your-order.png
:align: center
:alt: The Your Orders section of the dashboard, with the purchasing information highlighted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda think "Your Orders" or 'Your Orders' because it's syntactically disruptive if you don't call it out as a label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants