Skip to content

Conversation

dhrp-odoo
Copy link
Contributor

Description:

Steps to reproduce:

  • Create a new sheet (Sheet2).
  • On Sheet1, open the Data Validation side panel.
  • Add a DV with type "isValueInRange".
  • Click on the selection input to select the range.
  • Navigate to Sheet2 and select the range.
  • Click on Save without confirming the ranges.

Before this PR:

  • The DV was created on Sheet2 instead of remaining on Sheet1.

After this PR:

  • The DV is correctly created on the original sheet (Sheet1).

Task: 4948201

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Steps to reproduce:
- Create a new sheet (Sheet2).
- On Sheet1, open the Data Validation side panel.
- Add a DV with type "isValueInRange".
- Click on the selection input to select the range.
- Navigate to Sheet2 and select the range.
- Click on Save without confirming the ranges.

Before this commit:
- The DV was created on Sheet2 instead of remaining on Sheet1.

After this commit:
- The DV is correctly created on the original sheet (Sheet1).

Task: 4948201
@robodoo
Copy link
Collaborator

robodoo commented Sep 16, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants