[FIX] functions: wrong error message for SORT
#7165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bunch of problems in the errors messages of the `SORT`
and `SORTN` functions:
- we were using %d, which isn't supported
- the index displayed is always wrong
- we display the same index for both `SORT` and `SORTN` while they
have different number of mandatory arguments
- the message said we expected `a number or a range` while `is_ascending`
is a boolean
Task: 5085267
X-original-commit: 716824c
|
|
|
@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 19, 2025
There was a bunch of problems in the errors messages of the `SORT`
and `SORTN` functions:
- we were using %d, which isn't supported
- the index displayed is always wrong
- we display the same index for both `SORT` and `SORTN` while they
have different number of mandatory arguments
- the message said we expected `a number or a range` while `is_ascending`
is a boolean
closes #7165
Task: 5085267
X-original-commit: 716824c
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a bunch of problems in the errors messages of the
SORTandSORTNfunctions:SORTandSORTNwhile they have different number of mandatory argumentsa number or a rangewhileis_ascendingTask: 5085267
review checklist
Forward-Port-Of: #7163
Forward-Port-Of: #7135