[FIX] composer: set cursor on prettified formula #7166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Steps to reproduce: - type a long formula, e.g. =SUM(11111111, 22222222, 33333333, 44444444, 55555555, 66666666, 77777777, 88888888) - in the top bar composer, click somewhere that won't be on the first line when prettified (in the fours) => the cursor is badly positioned on the prettified formula Task: 5095470
LucasLefevre
force-pushed
the
19.0-prettified-cursor-lul
branch
from
05565e2 to
0658513
Compare
LucasLefevre
commented
Sep 17, 2025
Comment on lines
-154
to
-157
| const content = text || this.getComposerContent(this.getters.getActivePosition()); | ||
| const validSelection = this.isSelectionValid(content.length, selection.start, selection.end); | ||
| if (!validSelection) { | ||
| return; |
There was a problem hiding this comment.
This code looks like a safeguard against a programming error somewhere else, calling this with wrong values.
Keeping this check would mean making it more complex for ... not a lot...
LucasLefevre
commented
Sep 17, 2025
There was a problem hiding this comment.
not the mostly pretty fix I've written...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
=> the cursor is badly positioned on the prettified formula
Task: 5095470
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist