19.0 tutorials viwar by VIWAR-ODOO · Pull Request #1168 · odoo/tutorials

VIWAR-ODOO · 2026-02-16T07:22:57Z

completed till Chapter - 4

created a custom module
created the folder structure
created the model
added access rights in the ir.model.access.csv in the security folder

robodoo · 2026-02-16T07:23:00Z

VIWAR-ODOO · 2026-02-17T12:15:01Z

Chapter - 5 - Done Actions and Menus

created action
created the menu
created the three levels of menu
and created the first entry in the property - estate_model

Learned using `<data>` tag in the XML if we define `<data noupdate="1">` then records within it will be loaded when the module is installed, and without the noupdate="1" the records will get reloaded at module install and update.

VIWAR-ODOO · 2026-02-18T08:44:55Z

Chapter 5 done

added active and state field,
added the default values for some fields
added copy=false property to fields to not copy while duplicating
added the the 3months + from now as default date in the date availability field

mash-odoo

Hello!
Thank you for your work..
Here are some suggestions and questions..

estate/models/estate_property.py

estate/security/ir.model.access.csv

estate/views/estate_menus.xml

estate/__manifest__.py

estate/models/estate_property.py

Co-authored-by: mash-odoo <124269532+mash-odoo@users.noreply.github.com>

…n that

…tation and the garden area as default

VIWAR-ODOO · 2026-02-27T07:27:03Z

Chapter 8 COMPLETED

… on the estate after sold and ccancel

…ions in the estate property when accepting the offer and rejecting a one and in a combination - meeting the business use case, and also added the sold and cancel button in the estate property view

…sapear logic, - widget, -invisible logic, accept offer and reject all automatically , - replace the new function with a redundant function from the offer.py in the property.py

…mo data and linked tags and type to the property, as per the meeting

mash-odoo

Hello!
Thank you for your work.
Please keep in mind the coding guidelines. Do not leave unnecessary lines and spaces in the file. Keep a check on a proper indentation.
It's better to review a code if the readability is good otherwise it becomes difficult to understand the code blocks!
Leave one extra line at the end of the files.

mash-odoo · 2026-03-12T11:43:46Z

estate/data/estate_property_demo.xml

+<odoo>
+    <data >
+
+
+        <record id="estate_property_tag_1" model="estate.property.tag">
+                    <field name="id">1</field>
+                    <field name="name">tag1</field>
+        </record>
+
+        <record id="estate_property_type_1" model="estate.property.type">
+                    <field name="id">1</field>
+                    <field name="name">type1</field>
+        </record>
+
+        <record id="estate_property_1" model="estate.property">
+                    <field name="id">1</field>
+                    <field name="name">property</field>
+                    <field name="tag_ids" eval="[Command.set([ref('estate_property_tag_1')])]" />
+                    <field name="property_type_id">1</field>
+        </record>
+
+        <record id="estate_property_offer1" model="estate.property.offer">
+                    <field name="id">1</field>
+                    <field name="price">100000</field>
+                    <field name="property_id">1</field>
+        </record>
+
+
+    </data>
+</odoo>


Suggested change

<odoo>

<data >

<record id="estate_property_tag_1" model="estate.property.tag">

<field name="id">1</field>

<field name="name">tag1</field>

</record>

<record id="estate_property_type_1" model="estate.property.type">

<field name="id">1</field>

<field name="name">type1</field>

</record>

<record id="estate_property_1" model="estate.property">

<field name="id">1</field>

<field name="name">property</field>

<field name="tag_ids" eval="[Command.set([ref('estate_property_tag_1')])]" />

<field name="property_type_id">1</field>

</record>

<record id="estate_property_offer1" model="estate.property.offer">

<field name="id">1</field>

<field name="price">100000</field>

<field name="property_id">1</field>

</record>

</data>

</odoo>

<odoo>

<record id="estate_property_tag_1" model="estate.property.tag">

<field name="id">1</field>

<field name="name">tag1</field>

</record>

<record id="estate_property_type_1" model="estate.property.type">

<field name="id">1</field>

<field name="name">type1</field>

</record>

<record id="estate_property_1" model="estate.property">

<field name="id">1</field>

<field name="name">property</field>

<field name="tag_ids" eval="[Command.set([ref('estate_property_tag_1')])]" />

<field name="property_type_id">1</field>

</record>

<record id="estate_property_offer1" model="estate.property.offer">

<field name="id">1</field>

<field name="price">100000</field>

<field name="property_id">1</field>

</record>

</odoo>

I don't think there would be any use of this data tag unless you want to use it with noupdate

mash-odoo · 2026-03-12T11:47:54Z

estate/views/estate_property_visit_kanban_view.xml

+                        <t t-name="new">
+
+                        </t>


What is this used for?

mash-odoo

Please clean up the code.
I will resume the review after this.

mash-odoo · 2026-03-12T11:48:54Z

estate/views/estate_menus.xml

+            action="estate_property_visit_kanban_view"
+            />
+
+
+
+
+    </data>
+</odoo>


Suggested change

action="estate_property_visit_kanban_view"

/>

</data>

</odoo>

action="estate_property_visit_kanban_view"

/>

</odoo>

mash-odoo · 2026-03-12T11:49:17Z

estate/views/estate_property_tag_view.xml

+</record>
+
+
+
+
+
+
+</odoo>


Suggested change

</record>

</odoo>

</record>

</odoo>

mash-odoo · 2026-03-12T11:51:32Z

estate/views/estate_property_type_view.xml

+            <form string="Property Type">
+
+                <group><sheet>
+
+
+
+                <h1><field name="name"/><button string="" name="%(estate_property_offer_from_type_action)d" type="action" class="oe_stat_button btn btn-secondary">
+            <field name="offer_count"/>
+            </button>
+                </h1>
+
+
+
+
+                    <notebook>
+                         <page string="properties">
+
+
+
+
+
+                                        <list>
+                                            <field name="property_ids"/>
+                                        </list>
+
+
+
+
+                            </page>
+                    </notebook>
+
+
+
+                </sheet></group>


Can you please clean this up?

mash-odoo · 2026-03-12T11:52:19Z

estate/views/estate_property_view.xml

+                            <page string="maintainance request">
+                            <field name="estate_maintainance_id">
+
+                             <list default_order="id desc">
+
+                                        <field name="buyer_id"/>
+                                        <field name="technician_id"/>
+                                        <field name="state"/>
+                                        <field name="estimate_cost"/>
+                                        <field name="actual_cost"/>
+                                        <field name="current_stage"/>
+                            </list>
+
+                            </field>
+
+                            </page>


Clean up the code and follow proper indentation everywhere

VIWAR-ODOO added 12 commits February 5, 2026 19:30

[ADD] added estate module

2604af7

[FIX] delete test data

d82ef23

[FIX] added application true and installable as true

51763b2

[FIX] formate change of manifest file

dbcbc7a

[FIX] removed duplicate author fiels inthe manifest file

1b9af85

[FIX] style error removed white spaces

265e0f4

[FIX] no newline error in style fixed removed extra comma

0aaabf0

[FIX] formated code

5a196fc

[FIX] style error

e97eeb1

[FIX] new line at end , fix error no new newline at the end

2e78623

[CLN] remove description

21041c2

[FIX] restyle for test case eror

828ecf1

VIWAR-ODOO force-pushed the 19.0-tutorials-viwar branch 2 times, most recently from 5bea8cf to f0b55e5 Compare February 17, 2026 06:42

[ADD] added estate_property.py model

c2e6a0c

VIWAR-ODOO force-pushed the 19.0-tutorials-viwar branch from 8b0f9c3 to c2e6a0c Compare February 19, 2026 10:40

mash-odoo requested changes Feb 19, 2026

View reviewed changes

VIWAR-ODOO and others added 4 commits February 20, 2026 14:43

[IMP] estate: Update estate/models/estate_property.py

dc89be2

Co-authored-by: mash-odoo <124269532+mash-odoo@users.noreply.github.com>

[IMP] estate : added extra line

0134897

[IMP] estate: Update estate/models/estate_property.py

7955c6a

Co-authored-by: mash-odoo <124269532+mash-odoo@users.noreply.github.com>

[IMP] estate: removed <data> tag , and added "

230f419

VIWAR-ODOO force-pushed the 19.0-tutorials-viwar branch from 84323a2 to 230f419 Compare February 20, 2026 09:15

VIWAR-ODOO added 5 commits February 20, 2026 17:53

[ADD] estate: added the form view and a notebook and added two tabs i…

02685cc

…n that

[ADD] estate: search added, filter and domain added

bd0fb4d

[ADD] estate: added the property type , implemented the many2one

e055ab4

[LINT] estate: fix formatting to pass R&D tests

f943aba

[LINT] estate: fix styling , white space

7096674

VIWAR-ODOO added 8 commits February 24, 2026 13:07

[IMP] estate: added the the lambda function to acess the self.env._uid

465a892

[ADD] estate: added many2many , tag model and implementation

1f9a81a

[ADD] estate: added offers and implemented one2many

23f615e

[ADD] estate: added the depends compute field

16c7370

[ADD] estate: added the property offer

c6c5ce1

[ADD] estate: maintainance task done during the meeting

22d1eeb

[ADD] estate: adde the onchange on the garden to set the garden orien…

1784e4c

…tation and the garden area as default

[FIX] estate: fixed the style error

54239dd

VIWAR-ODOO force-pushed the 19.0-tutorials-viwar branch from f249e78 to 924b118 Compare March 2, 2026 05:33

[ADD] estate: added the button for the custom logic on the properties…

7814cfc

… on the estate after sold and ccancel

VIWAR-ODOO force-pushed the 19.0-tutorials-viwar branch from b1cd4e1 to 7814cfc Compare March 2, 2026 05:45

VIWAR-ODOO added 8 commits March 2, 2026 18:00

[ADD] estate: added the offer functionality

a5eb998

[FIX] estate: completed ch -8-9, fixed the actions on specific condit…

93381c4

…ions in the estate property when accepting the offer and rejecting a one and in a combination - meeting the business use case, and also added the sold and cancel button in the estate property view

[FIX] estate: fixed style error

3eec925

[ADD] estate: added some functionality as per the meeting - button di…

78f768b

…sapear logic, - widget, -invisible logic, accept offer and reject all automatically , - replace the new function with a redundant function from the offer.py in the property.py

[FIX] estate: fixed the styling error

1cf6ae6

[ADD] estate: done ch-10 and also completed the task of adding the de…

fe493f2

…mo data and linked tags and type to the property, as per the meeting

[ADD] estate: meeting task

37cabae

[ADD] estate: added ch-11

f378879

mash-odoo requested changes Mar 12, 2026

View reviewed changes

Conversation

VIWAR-ODOO commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

completed till Chapter - 4

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

VIWAR-ODOO commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chapter - 5 - Done Actions and Menus

Learned using <data> tag in the XML if we define <data noupdate="1"> then records within it will be loaded when the module is installed, and without the noupdate="1" the records will get reloaded at module install and update.

Uh oh!

VIWAR-ODOO commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chapter 5 done

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VIWAR-ODOO commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chapter 8 COMPLETED

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

mash-odoo Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mash-odoo Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

mash-odoo Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mash-odoo Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mash-odoo Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mash-odoo Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

VIWAR-ODOO commented Feb 16, 2026 •

edited

Loading

VIWAR-ODOO commented Feb 17, 2026 •

edited

Loading

Learned using `<data>` tag in the XML if we define `<data noupdate="1">` then records within it will be loaded when the module is installed, and without the noupdate="1" the records will get reloaded at module install and update.

VIWAR-ODOO commented Feb 18, 2026 •

edited

Loading

VIWAR-ODOO commented Feb 27, 2026 •

edited

Loading