[ADD] estate: Server Framework 101 implementation #789

Lud0do1202 · 2025-05-19T15:21:09Z

Server Framework 101

This PR follows the official Odoo backend tutorial:
🔗 https://www.odoo.com/documentation/18.0/developer/tutorials/server_framework_101.html

✅ Summary of features implemented:

Create models: EstateProperty, EstatePropertyType, EstatePropertyTag, EstatePropertyOffer
Add views: form, list, kanban, and search (with filters and groupings)
Implement business logic:
- Computed fields and onchange methods
- Actions: mark as sold, cancel, accept/refuse offers
- SQL and Python constraints (e.g. pricing, uniqueness)
UI improvements:
- Decorations (success, danger, etc.)
- Smart buttons (e.g. access related offers)
- Badges and conditional field attributes (readonly, invisible, optional)
Seller experience:
- Display properties by seller
- Restrict deletion to 'new' or 'cancelled' states
- Enforce offer price to be higher than current best
Set default ordering on models
Add a new module: estate_account
- Overrides the "mark as sold" action
- Automatically generates an invoice for the sold property

robodoo · 2025-05-19T15:21:13Z

barracudapps

Good job! And you're fast !

Here are some notes I suggest you to apply here and there in your code to fit Odoo's standards.
My comments are basically about readability and Git.

Don't forget to keep an eye on the runbot and apply needed changes to keep it green. The runbot is quite explicit and you can find your build here

🚀

barracudapps · 2025-05-19T16:27:52Z

estate/__manifest__.py

+    "name": "Real Estate",
+    "version": "1.0",
+    "description": "Real Estate Management System",
+    "summary": "Real Estate Management System",


Suggested change

"name": "Real Estate",

"version": "1.0",

"description": "Real Estate Management System",

"summary": "Real Estate Management System",

'name': 'Real Estate',

'version': '1.0',

'description': "Real Estate Management System",

'summary': 'Real Estate Management System',

Prefer using double quotes ("") for long strings, multiline or user inputs/displays.

barracudapps · 2025-05-19T16:28:01Z

estate/__manifest__.py

+    "version": "1.0",
+    "description": "Real Estate Management System",
+    "summary": "Real Estate Management System",
+    "author": "Lud0do1202",


Suggested change

"author": "Lud0do1202",

'author': 'Odoo',

Usually, we don't add the author on modules.
If you really want to keep it clean, please use "Odoo" (or "Odoo SA", ...) as your work for Odoo.

barracudapps · 2025-05-19T16:28:07Z

estate/__manifest__.py

+    "license": "LGPL-3",
+    "depends": ["base"],
+    "data": [
+        # Security


Suggested change

# Security

Avoid redundant information. The path already shows it's about security.

barracudapps · 2025-05-19T16:28:16Z

estate/__manifest__.py

+    "license": "LGPL-3",
+    "depends": ["base"],
+    "data": [
+        # Security
+        "security/ir.model.access.csv",
+        # Views
+        "views/estate_property_tag.xml",
+        "views/estate_property_type.xml",
+        "views/estate_property_offer.xml",
+        "views/estate_property.xml",
+        "views/estate_menus.xml",
+    ],
+    "auto_install": False,
+    "application": True,
+}


Suggested change

"license": "LGPL-3",

"depends": ["base"],

"data": [

# Security

"security/ir.model.access.csv",

# Views

"views/estate_property_tag.xml",

"views/estate_property_type.xml",

"views/estate_property_offer.xml",

"views/estate_property.xml",

"views/estate_menus.xml",

],

"auto_install": False,

"application": True,

}

'license': 'LGPL-3',

'depends': ['base'],

'data': [

# Security

'security/ir.model.access.csv',

# Views

'views/estate_property_tag.xml',

'views/estate_property_type.xml',

'views/estate_property_offer.xml',

'views/estate_property.xml',

'views/estate_menus.xml',

],

'auto_install': False,

'application': True,

}

barracudapps · 2025-05-19T16:28:30Z

estate/models/estate_property.py

+
+class EstateProperty(models.Model):
+    _name = "estate.property"
+    _description = "estate.property"


A description should be a bit more readable.

barracudapps · 2025-05-19T16:29:06Z

estate/views/estate_menus.xml

@@ -0,0 +1,13 @@
+<odoo>


Suggested change

<odoo>

<?xml version="1.0" encoding="utf-8"?>

<odoo>

Please, keep the XML declaration as it may cause issues with some parsers

barracudapps · 2025-05-19T16:29:12Z

estate/views/estate_menus.xml

@@ -0,0 +1,13 @@
+<odoo>
+    <!-- Root -->


Suggested change



The menuitem's id is explicit.

barracudapps · 2025-05-19T16:29:18Z

estate/views/estate_menus.xml

+    <menuitem id="settings_menu" name="Settings" parent="real_estate_root_menu" sequence="20"/>
+    <menuitem id="settings_property_types_menu" name="Property Types" action="estate_property_types_action" parent="settings_menu" sequence="10"/>
+    <menuitem id="settings_property_tags_menu" name="Property Tags" action="estate_property_tags_action" parent="settings_menu" sequence="10"/>


Suggested change

<menuitem id="settings_menu" name="Settings" parent="real_estate_root_menu" sequence="20"/>

<menuitem id="settings_property_types_menu" name="Property Types" action="estate_property_types_action" parent="settings_menu" sequence="10"/>

<menuitem id="settings_property_tags_menu" name="Property Tags" action="estate_property_tags_action" parent="settings_menu" sequence="10"/>

<menuitem id="settings_menu" name="Settings"

<menuitem id="settings_property_types_menu" name="Property Types" action="estate_property_types_action"/>

<menuitem id="settings_property_tags_menu" name="Property Tags" action="estate_property_tags_action"/>

</menuitem>

Nesting menus make it more readable.

barracudapps · 2025-05-19T16:29:30Z

estate/views/estate_property.xml

@@ -0,0 +1,123 @@
+<odoo>
+    <!--========= LIST =========-->


Suggested change



The record's `ids explicit.

barracudapps · 2025-05-19T16:29:39Z

estate/views/estate_property_offer.xml

+                <field name="price"/>
+                <field name="partner_id"/>
+                <field name="status"/>
+                <!-- ???? Cannot update a badge value ???? -->


Suggested change



Avoid sending questions in your code. Write a message to the person you want to ask the question, go discuss with that person or exchange on it in the Conversation section of your PR.

barracudapps

Check all your files, the newline is missing in some of them and required to get runbt green ✅

barracudapps · 2025-05-20T02:22:45Z

estate/security/ir.model.access.csv

+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
+estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
+estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
+estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1


Suggested change

estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

Always newline character at the end of your files for UNIX compatibility.

barracudapps · 2025-05-20T02:41:24Z

@Lud0do1202
Can you also please review the name of your PR and your commits titles/messages ?
Everything you need to know is here

barracudapps · 2025-05-20T10:28:27Z

@Lud0do1202
Goo job on commit and PR titles but you are working in the estate module. Not the real_estate one. 🙄

barracudapps

@Lud0do1202
Great changes integration!
Some comments though you'll find below and can you please rename your files to match standards? You can find the conventions here

barracudapps · 2025-05-20T10:28:42Z

.gitignore

+# Style
+pyproject.toml
+


Don't push your local configuration

barracudapps · 2025-05-20T11:18:48Z

estate/views/estate_menus.xml

+<odoo>
+    <menuitem id="real_estate_root_menu" name="Real Estate" sequence="10"/>
+
+    <!-- Advertissements -->


Suggested change



The name of the menu seems to be explicit

barracudapps · 2025-05-20T11:20:15Z

estate/views/estate_property.xml

+                    <!-- Title -->
+                    <h1>
+                        <field name="name" class="mb16"/>
+                    </h1>
+                    <group class="mb-2">
+                        <field name="tag_ids" widget="many2many_tags" options="{'color_field': 'color'}" nolabel="1"/>
+                    </group>


As this is the title, try to use oe_title class so it will follow future Odoo UI changes.

barracudapps · 2025-05-21T07:54:47Z

estate/models/estate_property.py

+        copy=False,
+        default=lambda self: fields.Date.today() + relativedelta(months=3),
+    )
+    expected_price = fields.Float(string='Expected Price', required=True)


Suggested change

expected_price = fields.Float(string='Expected Price', required=True)

expected_price = fields.Float('Expected Price', required=True)

FYI, you can bypass the explicit string parameter naming if set first as per Field's definition
Up to you.

barracudapps · 2025-05-21T08:02:12Z

estate/views/estate_property.xml

+                <field name="expected_price" string="Minimal Price" filter_domain="[('expected_price', '>=', self)]"/>
+                <field name="expected_price" string="Maximal Price" filter_domain="[('expected_price', '&lt;=', self)]"/>


Try harmonizing your code by following the same conventions

Does "harmonizing" here mean using >= and <= for XML safety ?
Because that’s what I did — let me know if you meant something else!

barracudapps · 2025-05-21T08:04:27Z

estate_account/models/estate_property.py

+        self.env['account.move'].create(
+            {


Suggested change

self.env['account.move'].create(

{

self.env['account.move'].create({

Depending on the team.
Up to you.

barracudapps · 2025-05-21T13:03:21Z

@Lud0do1202
Congrats for having finished the Python tutorial! 🥳
Can you please check if you considered everything I asked you to do before making Owl fly?
To help you get used to Odoo's standards, please make another branch for the Owl tutorial (and a new PR too), squash your commits related to the Python tutorial here into one, rename your PR to match your commit title and add a description to your PR so your reviewer understands why you did this.

barracudapps · 2025-05-21T13:19:14Z

estate/models/estate_property_offer.py

+            val_price = val.get('price')
+            val_property_id = val.get('property_id')


Avec you checked the behavior is correct when val_price and val_property_id are null ?
Maybe worth writing a test to ensure it never happens 🧐

barracudapps · 2025-05-21T13:19:20Z

estate/models/estate_property.py

+    ###### CRUD ######
+    def unlink(self):
+        if any(record.state not in ['new', 'cancelled'] for record in self):
+            raise UserError('You cannot delete a property that is not new or cancelled.')


Suggested change

raise UserError('You cannot delete a property that is not new or cancelled.')

raise UserError(self.env._('You cannot delete a property that is not new or cancelled.'))

As Séna would say:

In Odoo, translatable strings in "data"-type content are automatically exported for translation. However, other user-facing strings, Odoo cannot automatically know whether they are translatable. To ensure these strings are exported for translation, you need to explicitly mark them. This is achieved by wrapping the literal string with the self.env._() function. The _() function signals to Odoo's translation system that the string should be included in the translation catalog.

More info here: https://www.odoo.com/documentation/18.0/developer/howtos/translations.html#explicit-exports

You can check this line here:
https://github.com/odoo/odoo/blob/05cff3b7d866f6bc95c4b32f343ae14a4da946f2/addons/account/models/account_move.py#L2075

- Create models for properties, types, tags, and offers - Add views: form, list, kanban, search with filters and grouped displays - Implement business logic: compute fields, onchanges, actions (sold, cancel, accept, refuse), constraints (SQL and Python) - Use field attributes: readonly, invisible, optional - Apply UI enhancements: decorations, badges, smart buttons - Add seller-based property listings - Prevent deletion of properties unless in allowed states - Restrict offer creation to higher prices than existing ones - Add default ordering on models - Create estate_account module to generate an invoice upon property sale

barracudapps suggested changes May 19, 2025

View reviewed changes

barracudapps suggested changes May 20, 2025

View reviewed changes

Lud0do1202 force-pushed the 18.0-training-ltra branch from c98ef99 to 7ce73f4 Compare May 20, 2025 09:48

Lud0do1202 mentioned this pull request May 20, 2025

[ONBOARDING] --> chapter 6 (ltra) #785

Closed

Lud0do1202 changed the title ~~[ONBOARDING] --> chapter 8 (ltra)~~ [ADD] real_estate: onboarding up to chapter 9 May 20, 2025

barracudapps suggested changes May 20, 2025

View reviewed changes

barracudapps reviewed May 21, 2025

View reviewed changes

Lud0do1202 force-pushed the 18.0-training-ltra branch from 760e5cd to 00c56fc Compare May 21, 2025 14:23

Lud0do1202 changed the title ~~[ADD] real_estate: onboarding up to chapter 9~~ [ADD] estate: Server Framework 101 implementation May 21, 2025

	estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1
	estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

	expected_price = fields.Float(string='Expected Price', required=True)
	expected_price = fields.Float('Expected Price', required=True)

		<field name="expected_price" string="Minimal Price" filter_domain="[('expected_price', '>=', self)]"/>
		<field name="expected_price" string="Maximal Price" filter_domain="[('expected_price', '<=', self)]"/>

	self.env['account.move'].create(
	{
	self.env['account.move'].create({

		val_price = val.get('price')
		val_property_id = val.get('property_id')

	raise UserError('You cannot delete a property that is not new or cancelled.')
	raise UserError(self.env._('You cannot delete a property that is not new or cancelled.'))

		# Style
		pyproject.toml

[ADD] estate: Server Framework 101 implementation #789

Are you sure you want to change the base?

[ADD] estate: Server Framework 101 implementation #789

Uh oh!

Conversation

Lud0do1202 commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Server Framework 101

✅ Summary of features implemented:

Uh oh!

robodoo commented May 19, 2025

Uh oh!

barracudapps left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barracudapps commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barracudapps commented May 20, 2025

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barracudapps commented May 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lud0do1202 commented May 19, 2025 •

edited

Loading

barracudapps left a comment •

edited

Loading

barracudapps commented May 20, 2025 •

edited

Loading