Make sure to buffer the run after request_spsa. #2243
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdbergh
force-pushed
the
spsa3
branch
2 times, most recently
from
7d7511c to
ec5271a
Compare
If we don't this then the spsa_params for the workers may not survive a server restart. This fixes another issue with official-stockfish#2239.
|
You can add a bug label to this. Modifying a run object without buffering is a bug (the run will not be written to disk, even if the server is restarted cleanly). One may not always notice it since the run object may be buffered later after a different operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't this then the spsa_params for the workers may not survive a server restart.
This fixes another issue with #2239.