-
Notifications
You must be signed in to change notification settings - Fork 580
feat:report preview api #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nandkishorr
wants to merge
14
commits into
develop
Choose a base branch
from
nandkishorr/report_live_preview
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat:report preview api #3536
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bd4f2d2
feat:report preview api
nandkishorr 17f6e99
fix: update validation exceptions
nandkishorr 4ab9305
fix: added some validation exceptions
nandkishorr a0523dd
fix: typo
nandkishorr 5565b79
refact:updated the authz
nandkishorr 542cd38
refact:update the report read permission
nandkishorr c668a01
feat:added permission for preview api and encounter level
nandkishorr efbb881
Merge branch 'develop' into nandkishorr/report_live_preview
nandkishorr cf2ffb8
fix:authz fix
nandkishorr 84f7db9
Merge branch 'nandkishorr/report_live_preview' of https://github.com/…
nandkishorr 56b8379
feat:added report preview permission
nandkishorr 194a47e
Revert "feat:added report preview permission"
nandkishorr 05a0301
permission fix
nandkishorr 044a4d6
Add warnings on usage
vigneshhari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing template status check for preview.
The
generateaction validatestemplate.status != "active"(Line 125-126) before proceeding. Thepreviewaction skips this check entirely. This could allow previewing inactive or draft templates. If that's the intended behavior (designers previewing drafts), that's fine — but it's worth being explicit about it with a comment.🤖 Prompt for AI Agents