Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micro frontend refactor #3

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Micro frontend refactor #3

wants to merge 32 commits into from
+11,596 −3,018

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Dec 17, 2024 •
edited
Loading

Todo:

Frontend:

  • Update the ABHA generate/link form with new UI
  • Update the ABHA ID Card with the new UI
  • Create a util for making API calls
  • Import envs from core module
  • Show errors when the API sends non ok status
  • Add loaders to button while API calls are made
  • Wire Abha linking feature in patient home actions
  • Wire Abha linking feature in patient register form
  • Wire configure health facility
  • i18n
  • Wire raising consent request flow
  • Show records from ABDM

Backend:

  • Deprecate relations from facility app and use from emr app
  • Rewrite all serializer into pydantic specs
  • Rewire the fhir transformer util
  • Rethink creating care context logic

@khavinshankar
added vite configuration
bd92cbe
@khavinshankar
added shadcn and replaced classNames with cn
524d536
@khavinshankar
replaced CareIcon with lucide icon
1b7be68
@khavinshankar
duplicated required utils from core
3046843
@khavinshankar
replaced ButtonV2 with shadcn button
f87d3d4
@khavinshankar
replaced useQuery and request utils with tanstack query
f19d559
@khavinshankar
added required form fields, common components, utils from care core
49f559a
@khavinshankar
imported required types from core and refactored types
ac7e568
@khavinshankar
TEMP: removed context usages to fix errors
87bbe5a
@khavinshankar
cleanout existing abdm code and start fresh
e36869d
@khavinshankar
use translations from core repo
dd81dd2
@khavinshankar
use envs from core module
73b1bb8
@khavinshankar
wired abha linking feature in patient home actions
7f745d0
@khavinshankar
fixed styling conflicts with core app
0e37674
@khavinshankar
fixed styling conflicts with core app
d0bb665
@khavinshankar
wired abha linking feature in patient registration form
4972d48
rithviknishad
rithviknishad approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick pass, lgtm

src/apis/request.ts
@@ -0,0 +1,70 @@
const CARE_BASE_URL = __CORE_ENV__.REACT_CARE_API_URL || "";
const CARE_ACCESS_TOKEN_LOCAL_STORAGE_KEY = "care_access_token";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for now, but not a fan of making the plug assume the local storage's key (cookie based auth would've been nice maybe)

cc: @gigincg

@khavinshankar khavinshankar marked this pull request as ready for review January 21, 2025 07:53
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025 •
edited
Loading

Deploying care-abdm-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78a9b35
Status: ✅  Deploy successful!
Preview URL: https://add103e5.care-abdm-fe.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khavinshankar @rithviknishad