Fix: Resource filters in mobile view #10402

Rishith25 · 2025-02-05T01:52:34Z

Proposed Changes

Fixes Filter buttons not visible in mobile view for resource page #10381

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced the layout and responsiveness of the ResourceList component for improved user experience on all device sizes.
Style
- Updated the styling of the EmptyState paragraph for better visibility.
- Improved the layout of resource type and status tabs for a more flexible display.
- Made the Separator component visible on all screen sizes.
- Adjusted the status tabs for better content expansion and overflow handling.

coderabbitai · 2025-02-05T01:52:42Z

Walkthrough

The update modifies the ResourceList component to enhance its layout and visibility, particularly for responsive design. Changes include making previously hidden elements visible on all screen sizes, ensuring that resource type and status tabs are consistently displayed. The Separator component is now always visible, and adjustments have been made to allow better content expansion and display of status options.

Changes

File Path	Change Summary
`src/components/Resource/ResourceList.tsx`	Made elements visible on all screen sizes; updated `Separator` to always be visible; adjusted layout for status tabs with `h-auto` and `overflow-hidden`; enhanced `TabsList` for better responsiveness.

Assessment against linked issues

Objective	Addressed	Explanation
Filter buttons not visible in mobile view (#10381)	✅

Possibly related PRs

Fix: UI changes in shifting and resources pages #9437: Related updates in the ResourceList component for enhancing UI functionalities.
Design of List View layout in Resource Page #9096: Involves modifications to the ResourceList, specifically targeting resource card layout and rendering adjustments.

Suggested labels

needs review, tested

Suggested reviewers

shivankacker

Poem

Hop, hop, hop! I'm a little rabbit,
Skipping through code in a happy habit.
Tabs now flex, and styles are bright,
Filtering resources feels just right.
With every change, our UI sings,
A joyful dance as new code springs!
🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c816ee9 and 38177bf.

📒 Files selected for processing (1)

src/components/Resource/ResourceList.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Resource/ResourceList.tsx

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Redirect rules - care-ohc
GitHub Check: Header rules - care-ohc
GitHub Check: Pages changed - care-ohc
GitHub Check: cypress-run (1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-05T01:52:53Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`38177bf`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67aa06a8c673240008d9da4e
😎 Deploy Preview	https://deploy-preview-10402--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

src/components/Resource/ResourceList.tsx (3)

201-273: Add aria-labels to improve accessibility

The Select components should include aria-labels for better screen reader support.

Apply these changes to improve accessibility:

-                  <Select
+                  <Select aria-label={t("resource_type_selector")}
                     value={outgoing ? "outgoing" : "incoming"}
                     onValueChange={(value) =>
                       updateQuery({
                         outgoing: value === "outgoing",
                         title,
                       })
                     }
                   >

-                  <Select
+                  <Select aria-label={t("resource_status_group_selector")}
                     value={isActive ? "active" : "completed"}
                     onValueChange={(value) =>
                       updateQuery({
                         status: value === "active" ? "pending" : "completed",
                         title,
                       })
                     }
                   >

-                  <Select
+                  <Select aria-label={t("resource_detailed_status_selector")}
                     value={currentStatus}
                     onValueChange={(value) =>
                       updateQuery({
                         status: value,
                         title,
                       })
                     }
                   >

231-233: Differentiate between status selectors

Two different Select components use the same placeholder "Status" which might be confusing for users.

Consider using more descriptive placeholders:

-                      <SelectValue placeholder={t("Status")} />
+                      <SelectValue placeholder={t("Status Group")} />

-                      <SelectValue placeholder={t("Status")} />
+                      <SelectValue placeholder={t("Detailed Status")} />

Also applies to: 252-254

202-273: Add spacing between mobile selectors

The mobile selectors could benefit from consistent spacing for better visual hierarchy.

Add margin between the selectors:

-                <div className="md:hidden ">
+                <div className="md:hidden space-x-2">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d9273d and 75832b7.

📒 Files selected for processing (1)

src/components/Resource/ResourceList.tsx (3 hunks)

🔇 Additional comments (2)

src/components/Resource/ResourceList.tsx (2)

24-30: LGTM!

The Select component imports are well-organized and follow the established pattern.

62-62: LGTM!

Good improvement switching to semantic class name text-muted-foreground instead of direct color class.

shivankacker

I think creating a new component for mobile view will not work out well in the long run and will be redundant. Lets make the existing UI responsive.

Rishith25 · 2025-02-06T05:35:13Z

@shivankacker Is the above view is fine?

nihal467 · 2025-02-06T06:54:53Z

@shivankacker can you review it

rithviknishad

there are invalid classes in this change.

resource filters in mobile view

75832b7

Rishith25 requested a review from a team as a code owner February 5, 2025 01:52

coderabbitai bot reviewed Feb 5, 2025

View reviewed changes

Trigger Build

50bcb8d

shivankacker requested changes Feb 5, 2025

View reviewed changes

shivankacker added the changes required label Feb 5, 2025

Rishith25 added 2 commits February 6, 2025 10:21

Merge branch 'develop' into resource-filter

aff54a4

resource filters mobile view

c816ee9

Rishith25 requested a review from shivankacker February 6, 2025 05:35

nihal467 assigned shivankacker Feb 6, 2025

shivankacker approved these changes Feb 6, 2025

View reviewed changes

rithviknishad requested changes Feb 10, 2025

View reviewed changes

Rishith25 added 2 commits February 10, 2025 19:15

Merge branch 'develop' into resource-filter

c48621c

correct classNames

38177bf

Rishith25 requested a review from rithviknishad February 10, 2025 14:07

Jacobjeevan approved these changes Feb 11, 2025

View reviewed changes

Jacobjeevan unassigned shivankacker Feb 11, 2025

Jacobjeevan added needs review tested and removed changes required labels Feb 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Resource filters in mobile view #10402

Fix: Resource filters in mobile view #10402

Rishith25 commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 5, 2025 •

edited

Loading

coderabbitai bot left a comment

shivankacker left a comment

Rishith25 commented Feb 6, 2025

nihal467 commented Feb 6, 2025

rithviknishad left a comment

Fix: Resource filters in mobile view #10402

Are you sure you want to change the base?

Fix: Resource filters in mobile view #10402

Conversation

Rishith25 commented Feb 5, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 5, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 5, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

shivankacker left a comment

Choose a reason for hiding this comment

Rishith25 commented Feb 6, 2025

nihal467 commented Feb 6, 2025

rithviknishad left a comment

Choose a reason for hiding this comment

Rishith25 commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 5, 2025 •

edited

Loading