feat: ✨ Added platform helper #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pubdev says that the widget is not web compatible. This happens because there is an IO import being performed all the time.
The proposed change is to create a get that is in charge of telling if the operating system has shortcuts or not. Always import the web one that only has foundation and in case the compilation library is an IO one, export the get that has IO with the platform.
Actually it works in the web version even with the import because the check if is web happens first.
I think with this small change pubdev should detect it correctly and it helps to understand the reason for the if. If this is not the case you could implement an abstract class and implement it for each type of library whether it is html or io.