Skip to content

Commit

Permalink
Fix: ignore None as default parameter value (#14)
Browse files Browse the repository at this point in the history
  • Loading branch information
okgolove authored Apr 30, 2020
1 parent 420afdb commit 3ad985b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ build:
publish:
twine upload dist/*

jenkins-docker:
docker build --pull -t jenkins-test atest/docker
docker run --rm -p 127.0.0.1:8080:8080 -e JAVA_OPTS=-Djenkins.install.runSetupWizard=false -d jenkins-test

test:
robot --loglevel DEBUG --pythonpath src/ atest/

test-docker: jenkins-docker test
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[![Build Status](https://travis-ci.org/okgolove/robotframework-jenkins.svg?branch=master)](https://travis-ci.org/okgolove/robotframework-jenkins)
[![PyPI version](https://badge.fury.io/py/robotframework-jenkins.svg)](https://badge.fury.io/py/robotframework-jenkins)
![Supported Jenkins Version](https://img.shields.io/badge/jenkins-%3C%3D2.176.1-blue)
![Supported Jenkins Version](https://img.shields.io/badge/Tested%20with%20jenkins-%3E2.176.1%20%3C2.234-blue)

JenkinsLibrary for Robot Framework
==============================
Expand Down
5 changes: 4 additions & 1 deletion src/JenkinsLibrary/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ def get_job_parameters(self, name):
'name': param['name'],
'description': param['description'],
'type': param['type'],
'value': param['defaultParameterValue']['value']
# TODO: Add testcase with filepath parameter in a job
'value': param['defaultParameterValue'] if \
param['defaultParameterValue'] is None else \
param['defaultParameterValue'].get('value', None)
})
return params
2 changes: 1 addition & 1 deletion src/JenkinsLibrary/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = '2.0.0'
VERSION = '2.0.1'

0 comments on commit 3ad985b

Please sign in to comment.