Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option for infinite retries #7

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add an option for infinite retries #7

merged 1 commit into from
Aug 14, 2024

Conversation

okurz
Copy link
Owner

@okurz okurz commented Jun 17, 2024

No description provided.

@okurz
Copy link
Owner Author

okurz commented Jun 17, 2024

@mimi1vx @perlpunk @baierjan as previous contributors, would you like to look over this?

baierjan
baierjan reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@baierjan baierjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to handle -2? Otherwise looks good.

@okurz
Copy link
Owner Author

okurz commented Jun 17, 2024

Maybe you want to handle -2? Otherwise looks good.

I would actually have preferred 0 as a special setting but haven't found a clean way to introduce that.

@okurz okurz merged commit fd868ce into main Aug 14, 2024
5 checks passed
@okurz okurz deleted the feature/infinite_retries branch August 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baierjan baierjan baierjan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okurz @baierjan