Fix one-zone telnet power refresh handling#385
Open
davidjirovec wants to merge 1 commit intool-iver:mainfrom
Open
Fix one-zone telnet power refresh handling#385davidjirovec wants to merge 1 commit intool-iver:mainfrom
davidjirovec wants to merge 1 commit intool-iver:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
One-zone receivers can flap from off to on during telnet reconnect. The library already switched one-zone power control to PW, but telnet reconnect still queried ZM first and the main-zone power/state callbacks ignored PW events because they were routed to the All zone. That allowed stale power=ON state to survive long enough for an SI event to flip the media-player state back to on while the AVR was still in standby.
Testing