Fixed description bug #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated so that getDescription now looks at the doc string first, otherwise it uses the test name
Use the description as in the default template
Added description as the default
If there is no short description from the case then return a blank string
|
@oldani let me know if this looks good to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made this as a fix to this issue
#71
I fixed the
getDescriptionmethod to default to the doc strings first, otherwise use the method name. I also had to update the default template to use thetest_descriptionvariable as the default. Since the description is know defined as above. I think this would be a good default behavior because it matches your demo in the readme.If another outcome is needed the user can just change the template, but at least the
test_descriptionvariable is now correctHere is my test
