fix(bases): parse date-only strings as local calendar days - #385
Open
luabagg wants to merge 1 commit into
Open
Conversation
new Date("YYYY-MM-DD") is UTC midnight, so local getters can land on the previous day west of UTC. Construct local Date(y, m-1, d) for bare date-only inputs.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bases
date("YYYY-MM-DD")was parsed as UTC midnight, so in timezones west of UTC (e.g. Brazil) local day/month/year could land on the previous calendar day. Formulas and.format()should treat a bare date as that local calendar day.Summary
YYYY-MM-DDinputs in Basesdate()as local calendar days instead of UTC midnightnew Date(value)pathTest plan
TZ=UTC npx vitest run src/helpers/bases-engine/__tests__/exprEval.test.jsdate("2024-01-15")shows Jan 15 locally