fix(bases): compact note metadata for Bases queries - #387
Open
luabagg wants to merge 1 commit into
Open
Conversation
Stop embedding the full Eleventy data cascade (collections/graph/filetree/basesNotes) into every Bases note metadata bag. Keep frontmatter-ish fields with cycle-safe cloning.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bases notes were given
metadata: item.data, i.e. the full Eleventy data cascade. That embedscollections/graph/filetree/basesNotesinto every note, inflating memory on large vaults and creating circular structures. Bases formulas only need frontmatter-ish fields.Summary
compactNoteMetadatato strip Eleventy internals from Bases note metadatabasesNotesandnotes.11tydata.jsTest plan
TZ=UTC npx vitest run src/helpers/linkUtils.test.mjs