fix: move Bases engine files to filesToModify so updates reach existing gardens - #406
Merged
Conversation
…ng gardens Files under filesToAdd are skipped by the plugin's template updater when they already exist in a user's garden, so gardens that adopted Bases at 1.82.0 never received fixes to exprEval.js, linkUtils usage, etc. in later releases. filesToModify both creates missing files and updates changed ones, so the Bases engine, plugin, script, and stylesheet belong there. Reported in #816. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EDQTKUG4XFSGLwoJLcdk74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the template-update gap reported in #816 (comment).
TemplateManager.getFilesToAddin the plugin skips anyfilesToAddentry that already exists in the user's repo, so gardens that adopted Bases support at 1.82.0 never received the 1.83.x fixes toexprEval.jsand friends — users had to copy the files by hand.This moves all Bases-related files (the eight
bases-engine/modules,basesPlugin.js,basesScript.njk,obsidian-bases.scss) fromfilesToAddtofilesToModify. This is safe for gardens that don't have them yet:getPathsToModifyqueues missing files with an undefined sha, andaddOrUpdateFilescreates a file when no sha is passed.These files are engine code, not user-customizable (unlike
custom-style.scss/userSetup.js, which stay infilesToAdd), so overwriting on update is the intended behavior.🤖 Generated with Claude Code
https://claude.ai/code/session_01EDQTKUG4XFSGLwoJLcdk74