This repository was archived by the owner on Jul 15, 2018. It is now read-only.
Open
Conversation
Owner
|
Ben, thanks for this and sorry for not getting back to you sooner, been taking some time off. I had a quick look and there are quite a few changes here which I simply don't have the time to review as I'm no longer using this package myself. This is complicated by the fact that Travis CI seems to be failing all checks associated with this PR. You're welcome to fork this repo, introduce your changes and publish them to npm under a different name via your own account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Oleg,
Here is a simple proposition to comply with recent MongoDB API (3.X).
I'm not sure that I did it the right way, but the node test/test-fibers.js is ok! :D
In order to understand better your work could you explain me in detail what are the steps of the sync() function ? And could you check for exemple that the way I made DB.listCollections() is correct ?
Thank you !