Skip to content

Conversation

@lukecotter
Copy link
Contributor

  • Improves performance of scrolling in VirtualDomVertical by adding rows to the DOM in bulk using a DocumentFragment
  • Appears to resolve the issue described Tabulator vertical scroll skipping / jumping #3654 (although I have not tested that specific case)

Improves performance + appears to resolve a judder issue on scroll
@8483
Copy link

8483 commented Apr 5, 2025

I tried your fork, and the issue is still present...

I've attached a GIF (takes a second to load), look at the scroll bar.

tabulator

@lukecotter
Copy link
Contributor Author

lukecotter commented Apr 8, 2025

@8483 thanks for trying it. Can you add a Jsfiddle which shows the issue. Seeing your exact config really helps. I'll try see if I can work out what's happening.

The changes here completely solved the judder for me with datatree enabled.

Did these changes make things worse for you? Or just the same?

@TopTrainers
Copy link

@8483 thanks for trying it. Can you add a Jsfiddle which shows the issue. Seeing your exact config really helps. I'll try see if I can work out what's happening.

The changes here completely solved the judder for me with datatree enabled.

Did these changes make things worse for you? Or just the same?

The glitch starts to appear when you expand/collapse the tree. So when it happens, and you try to scroll up, it will scroll down a little bit by accident, then scroll up. And it always happens repeatedly. It's not the configuration. Because I try asking ai to create a demo page, it happens as soon as you expand/collapse the tree. But if you don't touch them, it will be fine for scrolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants