SASS upgrade - and extra header row removed #4809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added "rollup-plugin-sass" to handle the new sass library's roll-up function. * updated eslint to 9.3.6 (because there are serious breaking changes in SASS so need a new version of eslint). * removed extra header row from FreezeRows.js (code commented - not sure if it should be deleted) Notes: - 1. function4.scss was merged with variables4.scss because they depended on each other (new SASS can't handle circular dependencies) 2. function5.scss was merged with variables5.scss (same reason) 3. linting options are now in eslint.config.js 4. css maps are no longer generated - don't know why.
…d of a css file * restored origional rolllup plugin for stylesheet processing
Author
|
Hi people, Sorry - i see that my initial post is confusing. Let me try jump out of the details a bit - and give some context. and i wanted to fix it. The fix is easy - but i found that i could not build the project because npm would not let me install node-sass (since it's deprecated). So - then i tackled the whole "migrate to sass" issue. So now - the pull request is mostly about migrating from node-sass to sass (but the un-wanted The rest of the detail in the first post is about how I tried to make the changes as small as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of what this PR does: -
this was my original aim because of "Unwanted
element rendering after column headers in tabulator-header Unwanted <br> element rendering after column headers in tabulator-header #4783"
Notes on the details: -
I could not find a plugin using the newer "modern" API to generate a css file (the closest was "rollup-plugin-sass" - but it generated javascript code wrapping the CSS styles (all within the css file).
Maybe this is the new "modern" API - I don't know.
Because those changes are included in this pull request - but formatted a differently.
Total of 28 files changed (the rest are in the dist folder).
Sorry that I committed the dist folder changes (they were generated by the app). If this is a problem - I'll remove those changes from the pull request.
Finally - i didn't mean to make such a big PR. Was just trying to make a small change in 2 files.
The big PR was because I couldn't install node-sass (it's been deprecated, and my npm would not allow the install).
Despite all the changes - I'm pretty sure that I've preserved the styling.
(also - all the tests are passing)